Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding small fix for counting error #170

Merged
merged 2 commits into from
May 17, 2024

Conversation

romer8
Copy link
Collaborator

@romer8 romer8 commented May 17, 2024

  • Fixing line to see if outputs were generated with line

Final_Outputs_Count=$(find "$HOST_DATA_PATH/outputs/" -maxdepth 2 -type f | wc -l)

@jameshalgren
Copy link
Member

Is there a reason to limit depth to 2? Presumably, any file in the outputs folder is going to be useful to count...

@romer8
Copy link
Collaborator Author

romer8 commented May 17, 2024

@jameshalgren, I am assuming depth 2 in order to be similar to the cleaning outputs function in the guide.sh, but I can count any file in the output folder, but I wanted to be consistent to how the outputs were cleaned

@arpita0911patel arpita0911patel marked this pull request as ready for review May 17, 2024 21:20
Copy link
Member

@arpita0911patel arpita0911patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visualizer worked fine using guide script now with this PR so merging it.

@arpita0911patel arpita0911patel self-requested a review May 17, 2024 21:28
@arpita0911patel arpita0911patel merged commit 1e3de5a into CIROH-UA:main May 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants