Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ngen update #80

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Ngen update #80

merged 1 commit into from
Jan 17, 2024

Conversation

hellkite500
Copy link
Collaborator

Patches being applied in the ngen build steps are no longer needed as the upstream sources have merged similar patches. As such, these patches actually break the current build. This PR removes the old patch file and removes the patching step from the ngen build.

@ZacharyWills
Copy link

Bypassing branch protection as the build is failing for unrelated reasons:
https://github.com/CIROH-UA/NGIAB-CloudInfra/actions/runs/7558470899/job/20580067792?pr=80

This will allow local rebuilds of the main branch to still work.
Zach

@ZacharyWills ZacharyWills merged commit 6f67e3b into CIROH-UA:main Jan 17, 2024
4 of 6 checks passed
@CIROH-UA CIROH-UA deleted a comment from benlee0423 Jan 17, 2024
@benlee0423
Copy link

https://github.com/CIROH-UA/NGIAB-CloudInfra/actions/runs/7558470899/job/20580067792?pr=80

This is due to docker login secret is not in forked branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants