Added compiler flags for warnings in libopen1722.

Signed-off-by: Naresh Nayak <Naresh.Nayak@de.bosch.com>
COVESA · Dec 18, 2024 · 3568e6c · 3568e6c
1 parent ec44d97
commit 3568e6c
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 1 deletion.
diff --git a/examples/acf-can/acf-can-bridge.c b/examples/acf-can/acf-can-bridge.c
@@ -163,6 +163,8 @@ void* can_to_avtp_runnable(void* args) {
     // Invoke the spinning function to convert CAN frames to AVTP frames
     can_to_avtp(eth_socket, can_socket, can_variant, use_udp, use_tscf,
                 talker_stream_id, num_acf_msgs, dest_addr);
+
+    return NULL;
 }
 
 void* avtp_to_can_runnable(void* args) {

diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
@@ -32,6 +32,7 @@ set(LIB_NAME "${PROJECT_NAME}" )
 file(GLOB LIB_SOURCES *.c)
 
 add_library(${LIB_NAME} SHARED ${LIB_SOURCES})
+target_compile_options(${LIB_NAME} PRIVATE -Wall -Wextra)
 target_include_directories(${LIB_NAME} PRIVATE
     $<BUILD_INTERFACE:${CMAKE_SOURCE_DIR}/include>
     $<INSTALL_INTERFACE:include>)

diff --git a/src/avtp/acf/custom/CMakeLists.txt b/src/avtp/acf/custom/CMakeLists.txt
@@ -34,6 +34,7 @@ set(LIB_NAME "${PROJECT_NAME}custom" )
 file(GLOB LIB_SOURCES *.c)
 
 add_library(${LIB_NAME} SHARED ${LIB_SOURCES})
+target_compile_options(${LIB_NAME} PRIVATE -Wall -Wextra)
 target_include_directories(${LIB_NAME} PRIVATE
     $<BUILD_INTERFACE:${CMAKE_SOURCE_DIR}/include>
     $<INSTALL_INTERFACE:include>)

diff --git a/src/avtp/acf/custom/Vss.c b/src/avtp/acf/custom/Vss.c
@@ -576,7 +576,7 @@ void Avtp_Vss_SetVssData(Avtp_Vss_t* pdu, VssData_t* val) {
 void Avtp_Vss_SerializeStringArray(VssDataStringArray_t* vss_data_string_array,
                                    VssDataString_t* strings[], uint16_t num_strings) {
 
-    uint16_t total_length = 0, idx = 0;
+    uint16_t total_length = 0;
     uint8_t* data = vss_data_string_array->data;
     for (int i = 0; i < num_strings; i++) {
         total_length += strings[i]->data_length+2;