Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the trans tag with the required i18nKey #733

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

abhishekkumar08
Copy link

@abhishekkumar08 abhishekkumar08 commented Aug 6, 2020

⚠️ IMPORTANT: Please do not create a Pull Request without creating an Issue first.

All changes need to be discussed before proceeding. Failure to do so may result in the pull request being rejected.

Before submitting a pull request, please be sure to review:


Please include the issue number the pull request fixes by replacing YOUR-ISSUE-HERE in the text below.

Fixes #726

Summary

Details

Test Plan (required)

Final Checklist

  • For CoronaTracker, did you bump the version in package.json?
    • Update the second decimal for a major change
    • Update the third decimal for a minor change
    • Numbers can go past 9, e.g. 1.0.9 => 1.0.10
    • For more info, read about Semantic Versioning
  • Did you add any new tests as necessary?
  • Is your PR rebased off the most current master?
  • Have you squashed all commits? (can be done at merge)
  • Did you use yarn not npm? (important!)
  • Did you use Material-UI wherever possible?
  • Did you run yarn lint on the code?
  • Did you run all of your most recent changes locally to make sure everything is working?

@AdhamAH
Copy link
Member

AdhamAH commented Aug 17, 2020

@thedeveloperhere I didn't review the code yet. But couple of things:

  1. Please follow the PR template and provide the asked info.
  2. If you did the above you would run the test locally and travis wouldn't fail 😁 Please run the test locally and follow the instructions, you might need to press u or r I dont recall, to make new snapshot for the test. Or you can delete the snaps manually "Don't recommend"

Thanks and good luck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Add react-i18next tag to Cards components and page
2 participants