Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP History additional metadata #108

Merged
merged 2 commits into from
Jul 30, 2020
Merged

WIP History additional metadata #108

merged 2 commits into from
Jul 30, 2020

Conversation

zachlipton
Copy link
Collaborator

Follow-on to #107 that adds additional metadata fields to Batches and displays them in a popup in the history page

@zachlipton zachlipton requested a review from julia326 July 30, 2020 05:37
julia326
julia326 approved these changes Jul 30, 2020
View reviewed changes
Copy link
Collaborator

@julia326 julia326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great within the confines of the experiment :) merging

@julia326 julia326 merged commit 813e8db into display-history-for-date-state Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julia326 julia326 julia326 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zachlipton @julia326