fix(phirgen): emit barrier instructions as well #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asa-Kosto-QTM
previously approved these changes
Jan 30, 2024
neal-erickson
previously approved these changes
Jan 30, 2024
Should fix https://github.com/CQCL/phir/issues/53 Requires CQCL/phir#56 Also requires support for barrier instructions in pecos
qartik
dismissed stale reviews from Asa-Kosto-QTM and neal-erickson
via
c3ff464
Asa-Kosto-QTM
approved these changes
Feb 1, 2024
qciaran
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #119
Requires CQCL/phir#56 which I will release as phir v0.3.0
Needs support for barrier instructions in pecos / or a new pre-release with this change PECOS-packages/PECOS@1c9e365