[DB] Add Transactions (#12)

* cs# version bump

* add transaction method

* save cps with transaction;dot for millis

co-pilot = op

src/ST-DB/DB.cs

@@ -76,4 +76,33 @@ public async Task<int> Write(string query)
             }
         });
     }
+
+    public async Task Transaction(List<string> commands)
+    {
+        if (this._db == null)
+        {
+            throw new InvalidOperationException("Database connection is not open.");
+        }
+
+        using (var transaction = await this._db.BeginTransactionAsync())
+        {
+            try
+            {
+                foreach (var command in commands)
+                {
+                    using (var cmd = new MySqlCommand(command, this._db, transaction))
+                    {
+                        await cmd.ExecuteNonQueryAsync();
+                    }
+                }
+
+                await transaction.CommitAsync();
+            }
+            catch
+            {
+                await transaction.RollbackAsync();
+                throw; // rethrow the exception to be handled by the caller
+            }
+        }
+    }
 }

src/ST-Events/TriggerStartTouch.cs

@@ -96,10 +96,10 @@ internal HookResult OnTriggerStartTouch(DynamicHook handler)
 
                         // Add entry in DB for the run
                         if(!player.Timer.IsPracticeMode) {
-                            AddTimer(1.5f, () => {
+                            AddTimer(1.5f, async () => {
                                 player.Stats.ThisRun.SaveMapTime(player, DB); // Save the MapTime PB data
                                 player.Stats.LoadMapTimesData(player, DB); // Load the MapTime PB data again (will refresh the MapTime ID for the Checkpoints query)
-                                player.Stats.ThisRun.SaveCurrentRunCheckpoints(player, DB); // Save this run's checkpoints
+                                await player.Stats.ThisRun.SaveCurrentRunCheckpoints(player, DB); // Save this run's checkpoints
                                 player.Stats.LoadCheckpointsData(DB); // Reload checkpoints for the run - we should really have this in `SaveMapTime` as well but we don't re-load PB data inside there so we need to do it here
                                 CurrentMap.GetMapRecordAndTotals(DB); // Reload the Map record and totals for the HUD
                             });

src/ST-Player/PlayerHUD.cs

@@ -44,7 +44,7 @@ public static string FormatTime(int ticks, PlayerTimer.TimeFormatStyle style = P
         {
             case PlayerTimer.TimeFormatStyle.Compact:
                 return time.TotalMinutes < 1
-                    ? $"{time.Seconds:D1}:{millis:D3}"
+                    ? $"{time.Seconds:D1}.{millis:D3}"
                     : $"{time.Minutes:D1}:{time.Seconds:D1}.{millis:D3}";
             case PlayerTimer.TimeFormatStyle.Full:
                 return $"{time.Hours:D2}:{time.Minutes:D2}:{time.Seconds:D2}.{millis:D3}";

src/ST-Player/PlayerStats/CurrentRun.cs

@@ -75,9 +75,10 @@ INSERT INTO `MapTimes`
     /// Saves the `CurrentRunCheckpoints` dictionary to the database
     /// We need the correct `this.ID` to be populated before calling this method otherwise Query will fail
     /// </summary>
-    public void SaveCurrentRunCheckpoints(Player player, TimerDatabase DB)  // To-do: Transactions? Player sometimes rubberbands for a bit here
+    public async Task SaveCurrentRunCheckpoints(Player player, TimerDatabase DB)
     {
         int style = player.Timer.Style;
+        List<string> commands = new List<string>();
         // Loop through the checkpoints and insert/update them in the database for the run
         foreach (var item in player.Stats.ThisRun.Checkpoint)
         {
@@ -105,26 +106,22 @@ INSERT INTO `Checkpoints`
             #endif
 
             // Insert/Update CPs to database
-            // To-do: Transactions?
             // Check if the player has PB object initialized and if the player's character is currently active in the game
             if (item.Value != null && player.Controller.PlayerPawn.Value != null)
             {
-                Task<int> newPbTask = DB.Write($@"
+                string command = $@"
                     INSERT INTO `Checkpoints` 
                     (`maptime_id`, `cp`, `run_time`, `start_vel_x`, `start_vel_y`, `start_vel_z`, 
                     `end_vel_x`, `end_vel_y`, `end_vel_z`, `attempts`, `end_touch`) 
                     VALUES ({player.Stats.PB[style].ID}, {cp}, {runTime}, {startVelX}, {startVelY}, {startVelZ}, {endVelX}, {endVelY}, {endVelZ}, {attempts}, {ticks}) 
                     ON DUPLICATE KEY UPDATE 
                     run_time=VALUES(run_time), start_vel_x=VALUES(start_vel_x), start_vel_y=VALUES(start_vel_y), start_vel_z=VALUES(start_vel_z), 
                     end_vel_x=VALUES(end_vel_x), end_vel_y=VALUES(end_vel_y), end_vel_z=VALUES(end_vel_z), attempts=VALUES(attempts), end_touch=VALUES(end_touch);
-                ");
-                if (newPbTask.Result <= 0)
-                    throw new Exception($"CS2 Surf ERROR >> internal class Checkpoint : PersonalBest -> SaveCurrentRunCheckpoints -> Inserting Checkpoints. CP: {cp} | Name: {player.Profile.Name}");
-
-                newPbTask.Dispose();
+                ";
+                commands.Add(command);
             }
         }
-
+        await DB.Transaction(commands);
         player.Stats.ThisRun.Checkpoint.Clear();
     }
 }

src/SurfTimer.csproj

@@ -13,7 +13,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="CounterStrikeSharp.API" Version="1.0.147" />
+    <PackageReference Include="CounterStrikeSharp.API" Version="1.0.159" />
     <PackageReference Include="MaxMind.GeoIP2" Version="5.2.0" />
     <PackageReference Include="MySqlConnector" Version="2.3.1" />
   </ItemGroup>