Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds missing games to the rewarding system (BAL-191) #192

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

sebastianricaldoni
Copy link
Collaborator

@sebastianricaldoni sebastianricaldoni commented Apr 1, 2024

Adds missing games to the rewarding system

♻️ Current situation & Problem

After we removed and added some other games, we missed registering them in the rewarding system.
This means participants don't get rewarded for playing the following games:

  • Solitaire
  • 2048
  • Bouncing
  • Simon Says
  • Tetris

Refer to #191

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@sebastianricaldoni sebastianricaldoni self-assigned this Apr 1, 2024
@sebastianricaldoni sebastianricaldoni marked this pull request as ready for review April 1, 2024 13:49
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 3.74%. Comparing base (cd071cb) to head (9927742).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##            main    #192      +/-   ##
========================================
- Coverage   3.74%   3.74%   -0.00%     
========================================
  Files        133     133              
  Lines      11070   11075       +5     
========================================
  Hits         414     414              
- Misses     10656   10661       +5     
Files Coverage Δ
...lance/ActivityLogging/ActivityStorageManager.swift 3.50% <0.00%> (-0.12%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd071cb...9927742. Read the comment docs.

Copy link
Collaborator

@gperissetcelteeka gperissetcelteeka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebastianricaldoni sebastianricaldoni merged commit 64b87fa into main Apr 19, 2024
5 checks passed
@sebastianricaldoni sebastianricaldoni deleted the bug/BAL-191-SR-Games-Not-Rewarding-Coins branch April 19, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants