Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDSE to EO guide #1967

Merged
merged 39 commits into from
Mar 18, 2024
Merged

CDSE to EO guide #1967

merged 39 commits into from
Mar 18, 2024

Conversation

samumantha
Copy link
Contributor

@samumantha samumantha commented Jan 22, 2024

  • Removed one more mention of Sentinel mosaics on Puhti. Left Landsat there, as still available on Puhti.
  • Added general section about CDSE to EO-guide
  • Added landsat back to spatial data in Puhti page
  • Added direct read instructions for CDSE to GDAL cloud page (by Kylli)
  • Added some suggestions for download from CDSE
  • Added most of smaller suggestions from EO-guide improvement plans and suggestions - please comment  #1549

Please read if understandable and sufficient (or too much?) info + grammar check :)
@EetuHuuskoCSC, as you have nice and clean setup in Puhti, could you test if the instructions on using CDSE in GDAL cloud tutorial work for you on Puhti and if they are sufficient to set up the connection? A real life test so to say :)

https://csc-guide-preview.rahtiapp.fi/origin/swi_eoguide/support/tutorials/gis/eo_guide/

@samumantha samumantha changed the title WIP: CDSE to EO guide CDSE to EO guide Jan 30, 2024
@samumantha samumantha marked this pull request as ready for review January 30, 2024 18:30
Copy link
Contributor

@EetuHuuskoCSC EetuHuuskoCSC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor fix suggestions, one sentence that I could quite understand

docs/support/tutorials/gis/eo_guide.md Outdated Show resolved Hide resolved
docs/support/tutorials/gis/eo_guide.md Outdated Show resolved Hide resolved
docs/support/tutorials/gis/gdal_cloud.md Outdated Show resolved Hide resolved
docs/support/tutorials/gis/gdal_cloud.md Outdated Show resolved Hide resolved
docs/support/tutorials/gis/gdal_cloud.md Outdated Show resolved Hide resolved
docs/support/tutorials/gis/gdal_cloud.md Outdated Show resolved Hide resolved
samumantha and others added 2 commits January 31, 2024 10:07
Co-authored-by: EetuHuuskoCSC <116141296+EetuHuuskoCSC@users.noreply.github.com>
@EetuHuuskoCSC
Copy link
Contributor

Should this command work on Puhti?
$ gdalinfo /vsicurl/https://www.nic.funet.fi/index/geodata/mml/orto/normal_color_3067/mara_v_25000_50/2023/N33/02m/1/N3324F.jp2
@ktiits

Gives error: ERROR 4: /vsicurl/https://www.nic.funet.fi/index/geodata/mml/orto/normal_color_3067/mara_v_25000_50/2023/N33/02m/1/N3324F.jp2: No such file or directory

@EetuHuuskoCSC
Copy link
Contributor

Didn't get the gdalinfo reading working on Puhti, might be just on my end. However, I found a couple points in the gdal_cloud.md that might be added:

  1. A clearer indication that both the "S3 connection set up for Copernicus Data Space Ecosystem" and the "Several connection profiles" need to followed for being able to use CDSE on Puhti. If the idea is to be a more general tutorial and not connected to Puhti at all, this can be ignored
  2. Setting the environment variable "AWS_PROFILE" is given as Python code and above the environment variables are set via CLI. Adding CLI version after the Python code would make it clearer.
  3. Adding a link where to set up the CDSE credentials in the gdal_cloud.md could be beneficial as finding the right site through the main pages of Copernicus seems to be almost impossible

@ktiits
Copy link
Contributor

ktiits commented Feb 5, 2024

Should this command work on Puhti? $ gdalinfo /vsicurl/https://www.nic.funet.fi/index/geodata/mml/orto/normal_color_3067/mara_v_25000_50/2023/N33/02m/1/N3324F.jp2 @ktiits

Gives error: ERROR 4: /vsicurl/https://www.nic.funet.fi/index/geodata/mml/orto/normal_color_3067/mara_v_25000_50/2023/N33/02m/1/N3324F.jp2: No such file or directory

This is Puhti GDAL module problem, the commands are correct here. Will add a note to GDAL-page.

@ktiits
Copy link
Contributor

ktiits commented Feb 5, 2024

Didn't get the gdalinfo reading working on Puhti, might be just on my end. However, I found a couple points in the gdal_cloud.md that might be added:

  1. A clearer indication that both the "S3 connection set up for Copernicus Data Space Ecosystem" and the "Several connection profiles" need to followed for being able to use CDSE on Puhti. If the idea is to be a more general tutorial and not connected to Puhti at all, this can be ignored
  2. Setting the environment variable "AWS_PROFILE" is given as Python code and above the environment variables are set via CLI. Adding CLI version after the Python code would make it clearer.
  3. Adding a link where to set up the CDSE credentials in the gdal_cloud.md could be beneficial as finding the right site through the main pages of Copernicus seems to be almost impossible
  1. I updated the Readme file of download script in geocomputing Github. Does that look ok now?
  2. Changed to Linux style.
  3. CDSE links added to GDAL page.

@samumantha
Copy link
Contributor Author

Good to go from my end, thanks for comments and fixes

@ktiits ktiits changed the title CDSE to EO guide WIP: CDSE to EO guide Feb 12, 2024
Copy link
Contributor

@EetuHuuskoCSC EetuHuuskoCSC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor changes, otherwise LGTM

docs/support/tutorials/gis/eo_guide.md Outdated Show resolved Hide resolved
docs/support/tutorials/gis/eo_guide.md Outdated Show resolved Hide resolved
ktiits and others added 2 commits February 26, 2024 11:32
Co-authored-by: EetuHuuskoCSC <116141296+EetuHuuskoCSC@users.noreply.github.com>
Co-authored-by: EetuHuuskoCSC <116141296+EetuHuuskoCSC@users.noreply.github.com>
@ktiits ktiits changed the title WIP: CDSE to EO guide CDSE to EO guide Mar 18, 2024
@ktiits ktiits merged commit ce87609 into master Mar 18, 2024
3 checks passed
@ktiits ktiits deleted the swi_eoguide branch March 18, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants