Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/map datacite metadata to metax metadata #381

Conversation

genie9
Copy link
Contributor

@genie9 genie9 commented Mar 25, 2022

Description

This PR will add mapping between Datacite metadata Metax metadata

Related issues

closes #327

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (this needs a follow up PR)

Some of the changes COULD require changes to forms on the front end

Changes Made

  • Adds dedicated folder for Metax classes and resourses
  • Adds mapper class

Testing

  • Integration Tests

Mentions

@genie9 genie9 self-assigned this Mar 25, 2022
@genie9 genie9 marked this pull request as draft March 25, 2022 17:43
@genie9 genie9 force-pushed the feature/map-datacite-metadata-to-metax-metadata branch from 71d9efb to 5543f95 Compare March 29, 2022 17:43
genie9 and others added 19 commits March 29, 2022 17:45
Create handler for metax api calls. Update object handler to use metax api handler.
Create temporay functionality for adding doi id to object.
Adds metaxIdentifier to forbidden keys for db object update operations.
Add dataset and study test files for put and patch tests.
Add get endpoint to mock_metax_api.
Change operators functions responsible for metadata object creation to return full object data.
restrict one study per folder.
deprecate creating draft when publishing folder
prepare Study and Datasets DOI payload and relationships between them

for now url is omitted till Metax integration is done
we need to use find_one_and_update otherwise the bulkwrite will not be able to accurately catch it.

It is not by far the best solution, and can be improved
checking a set should be faster than checking a list
Move metax publishing before patching the folder

Split preparing DOI data for study and dataset to separate functions
It is possible to submit several metadata objects with each of own
file eg. submit endpoint. Till now only last file's filename was
extracted. That is now fixed.
Add loggings to object and metax api handlers and mock metax api
@genie9 genie9 force-pushed the feature/map-datacite-metadata-to-metax-metadata branch from 5543f95 to e0b132a Compare March 29, 2022 17:46
@genie9 genie9 closed this Mar 29, 2022
@genie9 genie9 deleted the feature/map-datacite-metadata-to-metax-metadata branch March 29, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants