-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/map datacite metadata to metax metadata #381
Closed
genie9
wants to merge
19
commits into
feature/metax-integration
from
feature/map-datacite-metadata-to-metax-metadata
Closed
Feature/map datacite metadata to metax metadata #381
genie9
wants to merge
19
commits into
feature/metax-integration
from
feature/map-datacite-metadata-to-metax-metadata
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genie9
force-pushed
the
feature/metax-integration
branch
from
March 29, 2022 15:42
b31cab9
to
487d539
Compare
genie9
force-pushed
the
feature/map-datacite-metadata-to-metax-metadata
branch
from
March 29, 2022 17:43
71d9efb
to
5543f95
Compare
Create handler for metax api calls. Update object handler to use metax api handler. Create temporay functionality for adding doi id to object.
Adds metaxIdentifier to forbidden keys for db object update operations.
Add dataset and study test files for put and patch tests. Add get endpoint to mock_metax_api.
Change operators functions responsible for metadata object creation to return full object data.
restrict one study per folder. deprecate creating draft when publishing folder
prepare Study and Datasets DOI payload and relationships between them for now url is omitted till Metax integration is done
we need to use find_one_and_update otherwise the bulkwrite will not be able to accurately catch it. It is not by far the best solution, and can be improved
checking a set should be faster than checking a list
Move metax publishing before patching the folder Split preparing DOI data for study and dataset to separate functions
It is possible to submit several metadata objects with each of own file eg. submit endpoint. Till now only last file's filename was extracted. That is now fixed.
Add loggings to object and metax api handlers and mock metax api
genie9
force-pushed
the
feature/map-datacite-metadata-to-metax-metadata
branch
from
March 29, 2022 17:46
5543f95
to
e0b132a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will add mapping between Datacite metadata Metax metadata
Related issues
closes #327
Type of change
Some of the changes COULD require changes to forms on the front end
Changes Made
Testing
Mentions