-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more file submission ops #633
Conversation
d63c922
to
d38bd8c
Compare
Looking good |
fad2b5c
to
c701b90
Compare
c701b90
to
ccf0a9e
Compare
70b54e6
to
e391824
Compare
changed base so that mypy fixes are included |
e391824
to
9247e64
Compare
9247e64
to
80b995b
Compare
9e42c1b
to
32f92fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a few things to nitpick but otherwise looks good to me
- fix comment in submission.py
- the files verified or completed don't need to be submitted again.
- we first check there are files that don't have any failed or added status, that would prevent a submission from being finalized
- this changes the op in patch
- remove and append return the document after update
- update specification for `/submission/<submission_id>/files` to update a submission with a list of files. Add the necessary operations for that in db-service and in file operator - remove file from submission when flag as deleted. Also enable to remove a specific file from submission - small fixes to description and specification.yml
- add changelog for file operation update and remove - add delete endpoint to remove a list of files identified by accession id - add endpoints in specification.yml
Co-authored-by: Joonatan Mäkinen <85632655+csc-jm@users.noreply.github.com>
0713bd7
to
6058bdf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Need to create an issue for tests.
I thought this was it: #629 |
Description
Related issues
related to: #148
continuation of #627
Type of change
Changes Made
ready
when being read from the submissionadded
(added but no metadata object) orfailed
(failed in ingestion, completion, or for any other reason) - in future version we can also check if the submission actually has files/submission/<submission_id>/files
receives a list of filesand transforms it to mongodb query for each file in
update_file_submission
e.g.:remove_file_submission
which is called when a file is flagged for deletion but can also be called whenever we want to remove all files with a specific accessionId or file path from one or multiple submissions/submission/<submission_id>/files
as one or multiple files can be marked as ready - will be used also MQ integration.Testing
Mentions
this is dependent on #642