Do not scroll to top when clicking challenge tabs #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f6b731d introduced a `href` attribute on the anchors used as Bootstrap tabs. As there is nothing in JS preventing the default click action, this causes this page to scroll to top (sorry). A simple fix would be to use `@onclick.prevent` with AlpineJS, but a cleaner fix is to use button elements. Using anchors as tabs does not really make sense here as users don't need to drag&drop the anchor.
|
I feel like there was a reason for a tags but it might just be lost to time. Trusting your judgement on this since I think you have much more experience with Bootstrap than I 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f6b731d introduced a
hrefattribute on the anchors used as Bootstrap tabs.As there is nothing in JS preventing the default click action, this causes this page to scroll to top (sorry).
A simple fix would be to use
@onclick.preventwith AlpineJS, but a cleaner fix is to use button elements. Using anchors as tabs does not really make sense here as users don't need to drag&drop the anchor.