Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix <select> dropdown background color #73

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Conversation

erdnaxe
Copy link
Contributor

@erdnaxe erdnaxe commented Mar 15, 2024

When using a dark-mode Bootstrap variant with a Chromium-based browser, <select> elements contain white text on white background.

This is due to main.scss overriding the background super property, discarding Bootstrap background-color property.

Also applying .form-control on select elements is non-standard and was contributing to this issue (https://getbootstrap.com/docs/5.0/forms/select/#default).

Before/after this patch:
before
after

@ColdHeat
Copy link
Member

I believe you need to rebuild the CSS files here. If you can do that I can merge pretty easily, if not I'm happy to build it for you as well.

@erdnaxe
Copy link
Contributor Author

erdnaxe commented Mar 15, 2024

Thanks! I was unsure about whether I should rebuild the CSS here as it could cause merge conflicts.

@ColdHeat ColdHeat merged commit f4b57b4 into CTFd:main Mar 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants