This repository has been archived by the owner on Sep 7, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 18
Piazza search (WiP) #126
Open
Sumukh
wants to merge
7
commits into
master
Choose a base branch
from
piazza-search
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Piazza search (WiP) #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knrafto
reviewed
Mar 22, 2017
let user = encodeURIComponent(this.props.state.currentUser.hash) | ||
|
||
if (description) { | ||
query += ' ' + description; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be sanitized
An idea on how to configure:
That way the client doesn't need to change between courses. |
I think the popup after clicking a feedback button is pretty annoying. You could use |
Thanks - going to try this out in the 3-4pm office hours. I'll be there to observe (or rollback if needed) |
I realized that this causes the buttons to jump around for the staff view. We should place the piazza search results below the buttons |
Ran the experiment and found that it didn't have enough usage to be interesting. It's been removed from production. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready for prime time but I would like to try this out in some 61A office hours
Known issues: