[Feature](mluOpSgetrf2): add LU parameter #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shunshen93
reviewed
Nov 19, 2024
mlu_op_test.proto
Outdated
| @@ -1119,6 +1121,11 @@ message FFTParam { | |||
| optional float scale_factor = 4 [default = 1.0]; | |||
| } | |||
|
|
|||
| // param to call Sgetrf2() | |||
| message Sgetrf2Param { | |||
Chuancysun
changed the title
shunshen93
reviewed
Nov 22, 2024
| @@ -1119,6 +1121,11 @@ message FFTParam { | |||
| optional float scale_factor = 4 [default = 1.0]; | |||
| } | |||
|
|
|||
| // param to call Sgetrf2() | |||
| message Sgetrf2Param { | |||
| optional int32 mode =1 [default = 1]; | |||
There was a problem hiding this comment.
https://github.com/Reference-LAPACK/lapack/blob/master/SRC/dgetrf2.f#L69
getrf这个算子，应该是支持原位修改输入的
There was a problem hiding this comment.
这个我们在最初时是做的原位的，但后来对接时需求更改为了非原位的
shunshen93
reviewed
Dec 3, 2024
| @@ -1119,6 +1121,11 @@ message FFTParam { | |||
| optional float scale_factor = 4 [default = 1.0]; | |||
| } | |||
|
|
|||
| // param to call Sgetrf2() | |||
| message Sgetrf2Param { | |||
| optional int32 mode =1 [default = 1]; | |||
There was a problem hiding this comment.
https://github.com/Reference-LAPACK/lapack/blob/master/SRC/dgetrf2.f#L69
getrf这个算子，应该是支持原位修改输入的
| @@ -256,7 +256,8 @@ enum OpType { | |||
| DYNAMIC_POINT_TO_VOXEL_BACKWARD = 404; | |||
| DYNAMIC_POINT_TO_VOXEL_FORWARD = 405; | |||
| EXPAND = 5; | |||
| FFT = 65536; | |||
| FFT = 65536; | |||
| SGETRF2 = 65537; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add LU parameter