Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use data types defined in the Rust Wren Engine to do type mapping #913

Merged
merged 3 commits into from
Nov 18, 2024
Merged

feat: Use data types defined in the Rust Wren Engine to do type mapping #913

merged 3 commits into from
Nov 18, 2024
+265 −204

Conversation

onlyjackfrost
Copy link
Collaborator

Use data types defined in the Rust Wren Engine to do type mapping

@github-actions github-actions bot added bigquery ibis trino python Pull requests that update Python code labels Nov 15, 2024
@onlyjackfrost onlyjackfrost changed the title Use data types defined in the Rust Wren Engine to do type mapping feat: Use data types defined in the Rust Wren Engine to do type mapping Nov 15, 2024
goldmedal
goldmedal approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@goldmedal goldmedal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @onlyjackfrost overall LGTM. Only one suggestion.

ibis-server/app/model/metadata/trino.py Outdated Show resolved Hide resolved
grieve54706
grieve54706 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@grieve54706 grieve54706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have tests.

@onlyjackfrost onlyjackfrost merged commit c4f00dc into main Nov 18, 2024
7 checks passed
@onlyjackfrost onlyjackfrost deleted the feature/rust-engine-data-type branch November 18, 2024 06:43
@grieve54706 grieve54706 added this to the 0.12.1 milestone Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grieve54706 grieve54706 grieve54706 approved these changes

@goldmedal goldmedal goldmedal approved these changes

Assignees
No one assigned
Labels
bigquery ibis python Pull requests that update Python code trino
Projects
None yet
Milestone
0.12.1
Development

Successfully merging this pull request may close these issues.
3 participants
@onlyjackfrost @goldmedal @grieve54706