Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added methods to check if below sea-level points were considered sea … #79

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

MichaelClerx
Copy link
Member

@MichaelClerx MichaelClerx commented Jun 19, 2024

…when the mask was generated and the sea slope was added.

@EricWay1024 this adds a method is_sea that accepts coordinates and tells you whether nevis thinks it's sea or not

Also a method inland_below_sea_level that returns coordinates for all grid squares below 0 but not considered sea.
This returns points in meters, but you can divide by 50 to get matrix indices.
Alternatively, we can expose the hidden method inland_below_sea_level_indices to return those directly.

…when the mask was generated and the sea slope was added.
@MichaelClerx MichaelClerx requested a review from EricWay1024 June 19, 2024 20:09
Copy link
Collaborator

@EricWay1024 EricWay1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@EricWay1024 EricWay1024 merged commit 5410a5c into main Jun 19, 2024
3 checks passed
@mirams mirams deleted the non-sea-mask branch June 19, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants