Refactor CI workflow #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This workflow will run on: - pushes to main, - pull requests against main, and - by manual invocation via GitHub's UI
- use CargoSense/setup-elixir-project reusable workflow - adds Ubuntu and macOS to the test matrix - specifies oldest and newest Elixir and Erlang combo in the matrix - use latest actions/checkout - sets job name to use matrix values for clarity
|
Error on the macOS job:
😭 |
jgarber623
force-pushed
the
github-actions-refactor
branch
from
d844164 to
540b967
Compare
jgarber623
commented
Aug 5, 2024
Turns out the underlying setup-beam workflow doesn't support macOS [1]. This change breaks out that OS into its own job whereby we ~~install Erlang and (some version of) Elixir using Homebrew~~ use ASDF to install the matrix'ed versions of Elixir and Erlang. I (originally) derived this solution from [2]. 🤞🏻 Let's see if it works! [1] erlef/setup-beam#54 [2] https://github.com/rusterlium/rustler/blob/master/.github/workflows/main.yml Squashed WIP commits with the following commit messages: - 0a42b83 YAML 🥴 - 5b9a38a Fix runs-on values - 95f2fd8 Try using asdf reusable workflow to install Elixir and Erlang - 1785e90 Update macOS job name - 3277cef Install Hex - 5d1d30d Install dependencies in macOS jobs
jgarber623
force-pushed
the
github-actions-refactor
branch
from
5d1d30d to
a0b8826
Compare
mcrumm
reviewed
Aug 5, 2024
mcrumm
reviewed
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR renames and refactors the project's GitHub Actions CI workflow. The updated workflow will now run on:
main,main, andNotable changes to the workflow include:
adds Ubuntu and macOS to the test matrixThe macOS job takes a necessarily different tact for installing Erlang and Elixir owing to the underlying
erlef/setup-beamworkflow not (yet) supporting macOS (see erlef/setup-beam#54).