Skip to content

Commit

Permalink
Merge pull request #1127 from skatlapa/fix_release
Browse files Browse the repository at this point in the history
Merged by Jenkins
  • Loading branch information
paas-bot authored May 6, 2019
2 parents 5cf2a12 + 9f65574 commit c3745cd
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions config/Dockerfiles/release-notes.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,15 +63,14 @@ def get_remaining_changes(pulls):
changes = []
# iterate over pulls backward so that list can be removed in place
for i in xrange(len(pulls) - 1, -1, -1):
skip = False
labels = pulls[i].get_labels()
for label in labels:
if label.name == "release":
skip = True
continue
else:
changes.append(pulls[i])
pulls.pop(i)
break
if not skip:
changes.append(pulls[i])
pulls.pop(i)
return changes


Expand Down Expand Up @@ -107,8 +106,9 @@ def format_body(tasks):
body['Other Changes'] = get_remaining_changes(tasks)

for title, items in body.items():
if len(items) == 0:
if not items:
continue

body_str += title + "\n"
for item in items:
body_str += "* {0} #{1} by {2}\n".format(item.title, item.number,
Expand Down

0 comments on commit c3745cd

Please sign in to comment.