[ENG-5879] Hide Categories Section on Registrations #2352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uditijmehta
force-pushed
the
eng-5879-hide-categories
branch
from
bea1380
to
060157a
Compare
Pull Request Test Coverage Report for Build 11296277310Details
💛 - Coveralls |
uditijmehta
force-pushed
the
eng-5879-hide-categories
branch
from
060157a
to
1fba6b6
Compare
brianjgeiger
requested changes
Oct 11, 2024
Comment on lines
30
to
38
| @tracked hideCategories = true; | ||
| // Private properties | ||
| expandCitations = false; | ||
|
|
||
| @task({ on: 'didReceiveAttrs'}) | ||
| @waitFor | ||
| async fetchProvider() { | ||
| this.provider = await this.registration?.provider; | ||
| this.hideCategories = true; |
There was a problem hiding this comment.
Do you need hideCategories to be tracked and set it in fetchProvider, or could you leave it untracked and only set it at declaration?
There was a problem hiding this comment.
@brianjgeiger I made hideCategories tracked in case we needed it to be dynamic in the future, but since it’s always true right now, I could remove it. Should we make it untracked to keep things simple?
There was a problem hiding this comment.
Yeah, let's keep it simple for now. I have a feeling it's more likely that we'll get rid of categories entirely rather than make it dependent on something else.
uditijmehta
force-pushed
the
eng-5879-hide-categories
branch
from
1fba6b6
to
49a60e2
Compare
uditijmehta
force-pushed
the
eng-5879-hide-categories
branch
from
49a60e2
to
e7aa290
Compare
brianjgeiger
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Hide Categories Section on Registrations
Summary of Changes