Fix value-search bugs #2388
Merged
Fix value-search bugs #2388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
futa-ikeda
changed the title
brianjgeiger
approved these changes
Nov 12, 2024
futa-ikeda
merged commit 1731732
into
CenterForOpenScience:feature/insti-dash-improv
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Summary of Changes
cardSearchFilter[affiliation]query-param to be an array, instead of a stringScreenshot(s)
defaultQueryParams.cardSearchFilter.affiliationnot being an array lead to this misformatted request param (array.concat vs. string.concat)Side Effects
QA Notes