Document tile selection algorithm #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-selection-algorithm
…-selection-algorithm
azrogers
reviewed
Dec 13, 2024
|
Looks good! Just a few questions. |
|
This is ready for another look. |
|
Thanks for writing this documentation, @kring! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR into #1032 so merge that first.
This is not a PR into #1022, but it does incorporate those changes. So merge that first, too.
This partially addresses #981.
There's definitely more to say about the tile selection algorithm, but I'm opening this PR now because:
In addition to the new document, this PR lightly refactors a few of the bits of code in the selection algorithm, in order to make them clearer and easier to write about. There shouldn't be any functional changes.