Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check to disable LOD transitions in material layer #1416

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

j9liu
Copy link
Contributor

@j9liu j9liu commented May 7, 2024

Follow up to #1414. Fixes #1104.

This PR does the following:

  • Renames UseLodTransitions to EnableLodTransitions, to keep consistent with the rest of the naming in Cesium3DTileset.
  • Adds a EnableLodTransitions parameter to the ML_DitherFade material layer, to control whether or not the dithering is applied.
  • Clarifies that EnableLodTransitions is only compatible with temporal AA modes in the comments.

This material parameter corresponds exactly with the Cesium3DTileset's parameter. When false, dithering won't be applied at all. This helps for projects that use non-temporal AA modes. As long as they don't enable LOD transitions (which would be user error), they don't need to worry about these dithering artifacts on their tilesets.

Before

image

After

image

image

@j9liu
Copy link
Contributor Author

j9liu commented May 7, 2024

Hm, the artifacts don't appear when Forward Rendering is disabled, even for non-temporal AA modes. So I'll adjust the documentation

Base automatically changed from fix-lod-fade to main May 20, 2024 12:15
@kring
Copy link
Member

kring commented May 21, 2024

@j9liu I see pretty significant artifacts in this branch when "Enable LOD Transitions" is enabled. It kind of looks like the old tile is being removed completely before the new one comes in, so I see big holes in the surface. This is with Google Photorealistic 3D Tiles:
image

I see the same thing with CWT+Bing, though.

@j9liu j9liu marked this pull request as draft September 27, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DitherFade material layer causes serious artifact with forward rendering / MSAA
2 participants