Initialize fields in FCesiumSampleHeightResult. #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j9liu
reviewed
Oct 31, 2024
| @@ -28,5 +28,5 @@ struct CESIUMRUNTIME_API FCesiumSampleHeightResult { | |||
| * will have more information about the problem. | |||
| */ | |||
| UPROPERTY(BlueprintReadWrite, Category = "Cesium") | |||
| bool SampleSuccess; | |||
| bool SampleSuccess{false}; | |||
There was a problem hiding this comment.
This is the biggest nitpick of all time, but in other classes or structs we tend to use = to initialize the default values, so I would like to change this to bool SampleSuccess = false 😅 Hopefully it's not too bad if I do that before merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unreal is reporting that the two fields in this class are not initialized. This is probably harmless, but good (and easy) to fix.
As reported here:
https://community.cesium.com/t/fcesiumsampleheightresult-errors/35906