-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose CesiumSunSky date and time properties to Sequencer #761
base: ue4-main
Are you sure you want to change the base?
Conversation
Thanks for the pull request @argallegos!
Reviewers, don't forget to make sure that:
|
There's actually a way to trigger UFUNCTIONs when sequencer-exposed variables are animated on a sequencer track: |
Thanks @xuelongmu, that would be great! |
Thanks again for your contribution @argallegos! No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with |
Hi, I tried adding the interp specifiers to the CesiumSunSky script in UE5 to expose the properties but does not reveal them in the sequencer. Are there other changes required to make this work with UE5? |
Adding Interp should work, but only if you recompile the plugin. Unreal won't automatically pick up code changes that you make to an Engine plugin. You can try copying the plugin to your project's Plugins directory instead. |
Great thanks for advice! |
Hi... I'm a newb and so apologize for what is probably a stupid question: How does one find the CesiumSunSky script in UE5, find the interp code necessary to expose the parameter in the sequencer, add the interp code, and then recompile the plugin. Any help you can offer will be hugely appreciated! |
If you've installed the plugin via the Epic Launcher, the code is usually found in |
This is beyond me, could you elaborate with a step-by-step instruction on how to make this work in UE5.3? |
No, we can't provide more detailed instructions than what I've already provided. If you have specific questions we may be able to answer them. Otherwise, you'll have to wait until this is incorporated into an official version of the plugin. |
Thanks for the answers. My specific question is: Is this supposed to also work in UE 5.3.2? On the instructions, the screenshots are for 4.26. |
As far as I know, the approach in this PR should work in 5.3.2 as well, but I haven't tried it. You will have to drag the CesiumSunSky Actor into the Sequencer, though, just like anything else you want to manipulate with the Sequencer. If that doesn't help, I'm afraid I don't know what the problem might be, sorry. |
Maybe I missed something, but what is the way to implement this PR? |
Sorry, I don't understand your question. |
Hi, finally managed to add the Interp specifier to CesiumSun&Sky properties in C++ file in Visual Studio, then tried to recompile plugin by copying the entire CesiumForUnreal folder (directory C:\Program Files\Epic Games\UE_5.1\Engine\Plugins\Marketplace) Starting to be a bit annoyed with all of these too complex settings :( |
That's normal when you put the plugin in your project directory.
I can't help you unless you tell me in what way it doesn't work.
Sorry you're having trouble, but keep in mind you're trying to make the plugin do something it isn't meant to do by modifying it. That's always going to have some complexity, especially if you're not used to working with C++ code bases and don't already have a development environment set up. |
Thank you for the following up Kevin. I understand that I'm trying to make the plugin do something it isn't meant to do. Hope there will be an update soon ! Once the CesiumforUnreal folder has been deplaced to Plugin folder, my uproject. don't open anymore. I have the "following modules are missing" error message and despite attempts to convert in C++ project (supposition found on forums) nothing works ... The only thing I can do is to trash the entire uproject and restart from zero |
@mathieuvannereux First, try putting the CesiumForUnreal folder in your project's plugin folder, rather than your installed Unreal version's plugin folder. If your .uproject file is at C:/Dev/my-project, the plugin folder should be C:/Dev/my-project/Plugins/CesiumForUnreal. You might need to create the plugins folder if it doesn't exist already. Second, you're going to need to use Unreal 5.2 or newer, or revert to Cesium for Unreal 2.5.0 (the last version that supported Unreal 5.1). Third, try right-clicking on your uproject file and selecting "Generate Visual Studio project files" (you might need to click "Show more options" at the bottom of the right click menu first). This will create a .sln which you should open. At the top of the window, the three dropdowns next to the start button should be set to "DebugGame Editor," "Win64," and whatever your project name is. Now click the play button in Visual Studio ("Local Windows Debugger") to build and launch the editor. |
|
See #760 - Previously, you could not animate the date or time in Sequencer. This PR exposes CesiumSunSky's Solar Time, Day, Month, Year, and Time Zone parameters to Sequencer.
Note that currently, CesiumSunSky's
UpdateSun
function must be called every frame in order for the animation to reflect in the scene. The best way I could find around that was to add a Repeater Event Track on CesiumSunSky in the sequencer, then binding that event to UpdateSun. Steps to do that below, since I'm not sure where else to document them:Of course, there's a lot that could be improved here - it would be great if people didn't have to add the event track. But I imagine that would involve refactoring the SunSky so this is probably enough for now.