Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Matrix Multiplication Shaders #12349

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

GGajanan1
Copy link

@GGajanan1 GGajanan1 commented Dec 1, 2024

Description

Fixed Matrix Multiplication in shaders
fixes #4250

Issue number and link

Testing plan

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

Copy link

github-actions bot commented Dec 1, 2024

Thank you for the pull request, @GGajanan1! Welcome to the Cesium community!

In order for us to review your PR, please complete the following steps:

Review Pull Request Guidelines to make sure your PR gets accepted quickly.

@GGajanan1
Copy link
Author

Thank you for the pull request, @GGajanan1! Welcome to the Cesium community!

In order for us to review your PR, please complete the following steps:

Review Pull Request Guidelines to make sure your PR gets accepted quickly.

@ggetz
Copy link
Contributor

ggetz commented Dec 9, 2024

Thanks @GGajanan1! I can confirm we have a CLA on file for you now.

Copy link
Contributor

@ggetz ggetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes so far @GGajanan1!

I think there are a few other places where this update is needed as well:

  • DepthPlaneVS.glsl
  • EllipsoidVS.glsl
  • GlobeVS.glsl
  • modelToWindowCoordinates.glsl

@GGajanan1
Copy link
Author

@ggetz Thanks , I have did the changes in the following PR:#12367

@GGajanan1 GGajanan1 closed this Dec 18, 2024
@GGajanan1 GGajanan1 deleted the fix/matrix-multiplication-in-shaders branch December 18, 2024 19:41
@GGajanan1 GGajanan1 restored the fix/matrix-multiplication-in-shaders branch December 18, 2024 19:41
@GGajanan1 GGajanan1 reopened this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check matrix multiplication in shaders
3 participants