-
-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: upgrade tyepscript to 5.6 #7160
base: unstable
Are you sure you want to change the base?
Conversation
@@ -225,7 +225,7 @@ export class Eth1DepositDataTracker { | |||
|
|||
// If remoteFollowBlock is not at or beyond deployBlock, there is no need to | |||
// fetch and track any deposit data yet | |||
if (remoteFollowBlock < this.eth1Provider.deployBlock ?? 0) return true; | |||
if (remoteFollowBlock < (this.eth1Provider.deployBlock ?? 0)) return true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch from TS update, could have been a logical bug.
"${configDir}/node_modules/@types", | ||
"${configDir}/types" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use template variables in configs now.
"${configDir}/node_modules/@types", | ||
"${configDir}/types" | ||
], | ||
"noCheck": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For building we can skip type checks as we have seperate task for check-types
. Saved 30% of build time on my machine.
https://devblogs.microsoft.com/typescript/announcing-typescript-5-6/#the---nocheck-option
cfa0efa
to
43d26f6
Compare
We need to put this on hold, until |
Performance Report✔️ no performance regression detected 🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
Motivation
Keep the deps updated.
Description
Use latest features provided by Typescript. See the comments below.
Steps to test or reproduce