feat: increase default gas limit to 36M #7304
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nflaig
added
the
status-do-not-merge
nflaig
commented
Dec 16, 2024
| @@ -131,7 +131,7 @@ type ValidatorData = ProposerConfig & { | |||
|
|
|||
| export const defaultOptions = { | |||
| suggestedFeeRecipient: "0x0000000000000000000000000000000000000000", | |||
| defaultGasLimit: 30_000_000, | |||
| defaultGasLimit: 36_000_000, | |||
There was a problem hiding this comment.
this is the relevant change, other changes are just examples or test data
nflaig
commented
Dec 16, 2024
Performance Report✔️ no performance regression detected Full benchmark results
|
nflaig
force-pushed
the
nflaig/increase-gas-limit
branch
from
b831eb5 to
372c9b4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #7304 +/- ##
=========================================
Coverage 48.76% 48.76%
=========================================
Files 601 601
Lines 40203 40203
Branches 2061 2061
=========================================
Hits 19607 19607
Misses 20558 20558
Partials 38 38 |
nflaig
removed
the
status-do-not-merge
|
this can be merged now |
g11tech
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To scale Ethereum L1 we want to increase the gas limit. I think it's best if clients signal what they consider as a safe limit instead of users having to figure this out themselves via websites like pumpthegas. 36M is pretty conservative but due to further considerations related to block size / gossip limit it's the max gas limit we should advocate for right now.
Description
Increase default gas limit to 36M
Note: This only affects builder blocks as the CL currently has no control over which (target) gas limit the local EL should use until something like ethereum/execution-apis#608 is implemented. Users must set the desired gas limit on the EL client via CLI flag or other means (depends on client).