-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing missing API Endpoints #91
base: develop
Are you sure you want to change the base?
Implementing missing API Endpoints #91
Conversation
How would I go about getting the IDs required for the Integration tests? I need the Metafield ID for the Customer Metafield for the below: ShopifyCustomerMetafieldUpdateRequest
.newBuilder()
.withCustomerId("6780238412")
.withMetafieldId("") // <----------------
.withValue("test_update")
.withValueType(MetafieldType.SINGLE_LINE_TEXT)
.build(); |
For the driver test it actually hits shopify. You need to specify the accesstoken and shopifySubdomain environment variables and you should be able to run on your shopify dev store with the values there. Note this is not run during the CI process and more for just a sanity check on the developers when we add these new interfaces. The values currently in the file are arbitrary. For the unit test, you can just mock out the values like we are in the other tests. This is run during the CI process and new code should be covered in there. |
@ryankazokas thanks for the clarification, I was under the impression that the integration tests were run as apart of the CI. I will run mine locally and then add unit tests. |
@ryankazokas this is ready for review so long. |
Please note I have published this to my local Github Packages repo, as I need the updates to continue my work. |
Thanks, can you switch the target to develop branch |
…939/shopify-sdk into feature/customer-metafields
Description of Changes
I am adding in a number of missing API endpoints that I need, I previously used this SDK in conjunction with my own code to make up for the missing features, but would prefer to use the SDK alone and remove redundant code in my codebase.
I am adding in: