Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user-created choices for selects #1117

Closed
wants to merge 2 commits into from

Conversation

joeworkman
Copy link
Contributor

Description

This is essentially a refactor of #525

I feel that this feature is important. I feel that the original was never merged in because of the amount of work it was to refactor it into Typescript.

Types of changes

  • Chore (tooling change or documentation change)
  • Refactor (non-breaking change which maintains existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project.
  • I have added new tests for the bug I fixed/the new feature I added.
  • I have modified existing tests for the bug I fixed/the new feature I added.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@rainbowRider5
Copy link

rainbowRider5 commented Oct 20, 2023

I'd love to see this feature finally merged. @jshjohnson, @mtriff any chances?

@land0r
Copy link

land0r commented Mar 29, 2024

Hello, any news? It's been without an answer for a while, maybe you have some plans and dates @jshjohnson, @mtriff
Thanks!

Xon added a commit to Xon/Choices.js that referenced this pull request Jul 23, 2024
@Xon Xon mentioned this pull request Aug 6, 2024
9 tasks
@Xon
Copy link
Collaborator

Xon commented Aug 6, 2024

Implemented as part of #1166

@Xon Xon closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants