Fixes an issue where passing in customProperties would render invalidly encoded object #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xon
reviewed
Jul 13, 2024
| @@ -321,7 +321,7 @@ const templates = { | |||
| const opt = new Option(label, value, false, active); | |||
|
|
|||
| if (customProperties) { | |||
There was a problem hiding this comment.
FYI, but this isn't a sufficient test for if a javascript object is empty
There was a problem hiding this comment.
Thank you for the feedback. I'll fix the tests and update the PR.
There was a problem hiding this comment.
@Xon I've updated the tests. Could you please let me know if this is correct. I'm not really great with JS as I majorly work on backends. Thank you.
|
Thanks, I've implemented a more comprehensive fix as part of #1166 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue where when passing in customProperties to a Choice would lead to render
[object Object]instead of properly rendering JSON structure.Types of changes
Checklist