Code cleanup. Moved BearingOfLine function to Direction, and ensured …

…that it takes into account the YIncreasesUpwards flag appropriately. This fixes issue #5. Updated documentation.
Chris3606 · Jan 26, 2018 · a6aeb54 · a6aeb54
1 parent 01e5066
commit a6aeb54
Show file tree

Hide file tree

Showing 83 changed files with 679 additions and 625 deletions.
diff --git a/GoRogue-PerformanceTests/App.config b/GoRogue-PerformanceTests/App.config
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <configuration>
-    <startup> 
-        <supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.6.2"/>
+    <startup>
+        <supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.6.2" />
     </startup>
-</configuration>
+</configuration>
diff --git a/GoRogue-PerformanceTests/GoRogue-PerformanceTests.csproj b/GoRogue-PerformanceTests/GoRogue-PerformanceTests.csproj
@@ -22,6 +22,7 @@
     <DefineConstants>DEBUG;TRACE</DefineConstants>
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
+    <NoWarn>RECS0145;</NoWarn>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
     <PlatformTarget>AnyCPU</PlatformTarget>
@@ -31,6 +32,7 @@
     <DefineConstants>TRACE</DefineConstants>
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
+    <NoWarn>RECS0145;</NoWarn>
   </PropertyGroup>
   <ItemGroup>
     <Reference Include="System" />

diff --git a/GoRogue-PerformanceTests/PathingTests.cs b/GoRogue-PerformanceTests/PathingTests.cs
@@ -1,8 +1,8 @@
 using GoRogue;
-using Generators = GoRogue.MapGeneration.Generators;
 using GoRogue.Pathing;
 using System;
 using System.Diagnostics;
+using Generators = GoRogue.MapGeneration.Generators;
 
 namespace GoRogue_PerformanceTests
 {

diff --git a/GoRogue-PerformanceTests/Program.cs b/GoRogue-PerformanceTests/Program.cs
@@ -1,5 +1,4 @@
 using GoRogue;
-using GoRogue.MapGeneration;
 using GoRogue.SenseMapping;
 using System;
 
@@ -59,7 +58,6 @@ private static void Main()
             Console.WriteLine($"Time for {ITERATIONS_FOR_TIMING} paths of Jump Point Search, on {MAP_WIDTH}x{MAP_HEIGHT} map:");
             Console.WriteLine($"\t{timeJumpPoint}");
             */
-
         }
     }
 }
diff --git a/GoRogue-PerformanceTests/Properties/AssemblyInfo.cs b/GoRogue-PerformanceTests/Properties/AssemblyInfo.cs
@@ -1,5 +1,4 @@
 using System.Reflection;
-using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 
 // General Information about an assembly is controlled through the following
@@ -33,4 +32,4 @@
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
 [assembly: AssemblyVersion("1.0.0.0")]
-[assembly: AssemblyFileVersion("1.0.0.0")]
+[assembly: AssemblyFileVersion("1.0.0.0")]
diff --git a/GoRogue-UnitTests/EffectTests.cs b/GoRogue-UnitTests/EffectTests.cs
@@ -1,6 +1,6 @@
-using System;
+using GoRogue;
 using Microsoft.VisualStudio.TestTools.UnitTesting;
-using GoRogue;
+using System;
 
 namespace GoRogue_UnitTests
 {
@@ -23,6 +23,7 @@ protected override void OnTrigger(EffectArgs e)
             e.CancelTrigger = true;
         }
     }
+
     [TestClass]
     public class EffectTests
     {
@@ -125,4 +126,4 @@ public void EffectTriggerEffects()
             Assert.AreEqual(1, secEffectTrigger.Effects[0].Duration); // Must have cancelled
         }
     }
-}
+}
diff --git a/GoRogue-UnitTests/GoRogue-UnitTests.csproj b/GoRogue-UnitTests/GoRogue-UnitTests.csproj
@@ -29,6 +29,7 @@
     <DefineConstants>DEBUG;TRACE</DefineConstants>
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
+    <NoWarn>RECS0145;</NoWarn>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
     <DebugType>pdbonly</DebugType>
@@ -37,6 +38,7 @@
     <DefineConstants>TRACE</DefineConstants>
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
+    <NoWarn>RECS0145;</NoWarn>
   </PropertyGroup>
   <ItemGroup>
     <Reference Include="Microsoft.VisualStudio.TestPlatform.TestFramework, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">

diff --git a/GoRogue-UnitTests/MapAreaTests.cs b/GoRogue-UnitTests/MapAreaTests.cs
@@ -1,8 +1,8 @@
 using GoRogue;
 using GoRogue.MapGeneration;
-using Generators = GoRogue.MapGeneration.Generators;
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 using System;
+using Generators = GoRogue.MapGeneration.Generators;
 
 namespace GoRogue_UnitTests
 {

diff --git a/GoRogue-UnitTests/MapGenTests.cs b/GoRogue-UnitTests/MapGenTests.cs
@@ -1,9 +1,9 @@
 using GoRogue;
 using GoRogue.MapGeneration;
-using Generators = GoRogue.MapGeneration.Generators;
 using GoRogue.Random;
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 using System;
+using Generators = GoRogue.MapGeneration.Generators;
 
 namespace GoRogue_UnitTests
 {

diff --git a/GoRogue-UnitTests/MathHelperTests.cs b/GoRogue-UnitTests/MathHelperTests.cs
@@ -1,5 +1,4 @@
 using GoRogue;
-using System;
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 
 namespace GoRogue_UnitTests
@@ -23,4 +22,4 @@ public void RoundToMultiple()
             Assert.AreEqual(0, result);
         }
     }
-}
+}
diff --git a/GoRogue-UnitTests/MultiSpatialMapTests.cs b/GoRogue-UnitTests/MultiSpatialMapTests.cs
@@ -1,5 +1,5 @@
-using Microsoft.VisualStudio.TestTools.UnitTesting;
-using GoRogue;
+using GoRogue;
+using Microsoft.VisualStudio.TestTools.UnitTesting;
 
 namespace GoRogue_UnitTests
 {
@@ -153,4 +153,4 @@ public void MultiSpatialMapRemove()
             Assert.AreEqual(0, count);
         }
     }
-}
+}
diff --git a/GoRogue-UnitTests/Properties/AssemblyInfo.cs b/GoRogue-UnitTests/Properties/AssemblyInfo.cs
@@ -1,5 +1,4 @@
 using System.Reflection;
-using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 
 [assembly: AssemblyTitle("GoRogue-UnitTests")]
@@ -10,11 +9,9 @@
 [assembly: AssemblyCopyright("Copyright ©  2018")]
 [assembly: AssemblyTrademark("")]
 [assembly: AssemblyCulture("")]
-
 [assembly: ComVisible(false)]
-
 [assembly: Guid("d421d454-9249-48cf-9f19-d17690615019")]
 
 // [assembly: AssemblyVersion("1.0.*")]
 [assembly: AssemblyVersion("1.0.0.0")]
-[assembly: AssemblyFileVersion("1.0.0.0")]
+[assembly: AssemblyFileVersion("1.0.0.0")]
diff --git a/GoRogue-UnitTests/RadiusFOVSyncTests.cs b/GoRogue-UnitTests/RadiusFOVSyncTests.cs
@@ -1,8 +1,8 @@
-using System;
-using GoRogue;
-using Generators = GoRogue.MapGeneration.Generators;
+using GoRogue;
 using GoRogue.SenseMapping;
 using Microsoft.VisualStudio.TestTools.UnitTesting;
+using System;
+using Generators = GoRogue.MapGeneration.Generators;
 
 namespace GoRogue_UnitTests
 {
@@ -178,4 +178,4 @@ private void printArray(bool[,] arr)
             }
         }
     }
-}
+}
diff --git a/GoRogue-UnitTests/SpatialMapTests.cs b/GoRogue-UnitTests/SpatialMapTests.cs
@@ -3,7 +3,7 @@
 
 namespace GoRogue_UnitTests
 {
-    class MyIDImpl : IHasID
+    internal class MyIDImpl : IHasID
     {
         private static IDGenerator idGen = new IDGenerator();
         public uint ID { get; private set; }
@@ -156,4 +156,4 @@ public void SpatialMapRemove()
             Assert.AreEqual(0, count);
         }
     }
-}
+}
diff --git a/GoRogue/ArrayMapOf.cs b/GoRogue/ArrayMapOf.cs
@@ -12,6 +12,7 @@ public class ArrayMapOf<T> : ISettableMapOf<T>, ICloneable
         /// The width of the array.
         /// </summary>
         public int Width { get => array.GetLength(0); }
+
         /// <summary>
         /// The height of the array.
         /// </summary>