Merge pull request #31 from kuzmany/fix-by-rectors

Code improvements. Thanks @kuzmany
ChrisRAoW · Mar 22, 2021 · d553204 · d553204
2 parents 2fac5a5 + f3294de
commit d553204
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/Parser/ItemTag.php b/Parser/ItemTag.php
@@ -56,7 +56,6 @@ public function getValue()
                 break;
             case 'author':
                 $author = $feedItem->get_author();
-                $value  = '';
 
                 if (!is_null($author)) {
                     $value = $author->get_link();

diff --git a/Parser/Parser.php b/Parser/Parser.php
@@ -9,7 +9,7 @@ class Parser
 {
     use ParamsTrait;
 
-    protected $content = null;
+    protected $content;
 
     public function __construct($content, $event)
     {
@@ -46,12 +46,7 @@ public function __construct($content, $event)
     public function validateFeedUrl($url)
     {
         $url = trim($url);
-
-        if (empty($url) || !filter_var($url, FILTER_VALIDATE_URL)) {
-            return false;
-        }
-
-        return true;
+        return !empty($url) && filter_var($url, FILTER_VALIDATE_URL);
     }
 
     public function setContent($content)