Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: Fix DataTable pageLength value #7169

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

bigtigerku
Copy link
Contributor

@bigtigerku bigtigerku commented Sep 27, 2024

Description & Issue number it closes

Screenshots (if appropriate)

Info at the bottom of the table has leading zero(010).

Showing 1 to 010 of 41 entries

Screenshot 2024-09-27 at 3 29 07 PM

Second page displays more than expected

Screenshot 2024-09-27 at 3 29 32 PM

Same issue in the other tables too

Showing 1 to 010 of 213 entries

Screenshot 2024-09-27 at 3 30 15 PM

Second page displays Showing 11 to 213 of 213 entries

Screenshot 2024-09-27 at 3 30 29 PM

After fix

Info at the bottom of the table has no leading zero.

Showing 1 to 10 of 41 entries
Screenshot 2024-09-27 at 3 31 54 PM

Second page displays 10 elements

Screenshot 2024-09-27 at 3 38 35 PM

How to test the changes?

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Docker

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bigtigerku bigtigerku requested a review from a team as a code owner September 27, 2024 22:48
@bigtigerku bigtigerku requested review from respencer, DawoudIO, grayeul, DAcodedBEAT and MrClever and removed request for a team September 27, 2024 22:48
@DawoudIO DawoudIO merged commit 1661c45 into ChurchCRM:master Sep 27, 2024
5 checks passed
@DAcodedBEAT DAcodedBEAT added this to the 5.11.0 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants