removed temp fix (sort direct pair responses) for delivery engine error

Citolab · Apr 18, 2024 · ca71dff · ca71dff
1 parent 856f9e4
commit ca71dff
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 10 deletions.
diff --git a/Scoring.Tests/Resources/30/ResponseProcessing/gap-match-result.xml b/Scoring.Tests/Resources/30/ResponseProcessing/gap-match-result.xml
@@ -44,10 +44,10 @@
         </outcomeVariable>
         <responseVariable identifier="RESPONSE" cardinality="single" baseType="directedPair">
             <candidateResponse>
-                <value>HSA B</value>
-                <value>HSB D</value>
-                <value>HSC C</value>
-                <value>HSD A</value>
+                <value>B HSA</value>
+                <value>D HSB</value>
+                <value>C HSC</value>
+                <value>A HSD</value>
             </candidateResponse>
         </responseVariable>
     </itemResult>

diff --git a/Scoring/Helpers/Helper.cs b/Scoring/Helpers/Helper.cs
@@ -147,11 +147,11 @@ internal static bool CompareSingleValues(string value1, string value2, BaseType
                         {
                             // sort values because order is not important
                             // WORKAROUND TO SUPPORT DIRECT PAIRS MIXED UP. ACTUALLY SHOULD ONLY BE SORTED FOR PAIRS
-                            // if (baseType == BaseType.Pair)
-                            // {
-                            pair1.Sort();
-                            pair2.Sort();
-                            // }
+                            if (baseType == BaseType.Pair)
+                            {
+                                pair1.Sort();
+                                pair2.Sort();
+                            }
                             return string.Join(" ", pair1) == string.Join(" ", pair2);
                         }
                         else

diff --git a/Scoring/ScoringEngine.csproj b/Scoring/ScoringEngine.csproj
@@ -5,7 +5,7 @@
 		<RootNamespace>Citolab.QTI.ScoringEngine</RootNamespace>
 		<ProjectGuid>{2A7091CD-6A49-4B7B-85BB-A140C8B5397C}</ProjectGuid>
 		<PackageId>Citolab.QTI.ScoringEngine</PackageId>
-		<Version>1.3.0</Version>
+		<Version>1.3.1</Version>
 		<Company>Cito</Company>
 		<Copyright>Stichting Cito Instituut voor Toetsontwikkeling, Arnhem (2023)</Copyright>
 		<Authors>Citolab</Authors>

diff --git a/release_notes.md b/release_notes.md
@@ -1,3 +1,7 @@
+## 1.3.1
+
+- removed temp fix for delivery engine error to sort directPairs. Only pairs are sorted as the QTI spec describes.
+
 ## 1.3.0
 
 - support: qti-max + qti-min