Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/setup nav links components #27

Merged
merged 5 commits into from
Jul 24, 2023

Conversation

ClaudiaRojasSoto
Copy link
Owner

This pull request aims to merge the config-and-basic-setup branch into the develop branch of the repository. I have completed all the specific and general requirements for the basic project setup, as well as the following points:

Details

Config & Basic Setup:

  • Download the free image for the app logo.
  • Create routes and view components: rockets, missions, and my profile. I added the functionality to include "dragons" only if the team consists of 3 members.
  • Use components for navigation links with active styling to indicate the selected section/page.

Redux State Slice Directories:

  • Create separate directories for rockets, missions, and, if required, dragons files for state management with Redux and add content as a prove.

General Requirements:

  • Fix all linter errors and follow the correct Gitflow workflow.
  • Maintain a consistent code structure and applied best practices for HTML, CSS, and JavaScript.
  • Document all work, providing explanatory comments in the code and a detailed description of this pull request.

I appreciate your time in reviewing and approving this pull request. If there are any suggestions or further improvements, I'll be happy to make the necessary changes.

Thank you for reviewing and considering this pull request for merging into the "develop" branch!
@ClaudiaRojasSoto

@ClaudiaRojasSoto ClaudiaRojasSoto linked an issue Jul 24, 2023 that may be closed by this pull request
Copy link
Collaborator

@CesarHerr CesarHerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APPROVED 🟢

Hi @ClaudiaRojasSoto ,

Congratulations!GIF

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

(Highlights) Good Points: 👍

  • Well done Creating the setup.🎉 🎉 🎉 ✔

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@ClaudiaRojasSoto ClaudiaRojasSoto merged commit a607d8c into develop Jul 24, 2023
3 checks passed
@ClaudiaRojasSoto ClaudiaRojasSoto linked an issue Jul 24, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1pt] Create empty My profile - Setup (group task) [1pt] Create basic structure for Rockets - Setup
2 participants