-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/header setup #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CesarHerr great job so far! your work almost 💯 👍 , but there is one thing that I think is really necessary and we need to include before approving this PR. You can find my suggestion below the review:
Highlights:
- Great design
- No linter errors
- You follow the right workflow
Changes:
- Include the Licence file to have a valid link on the Readme file.
Including a license in GitHub repositories is essential for protecting your copyright, encouraging collaboration, demonstrating transparency, safeguarding users' rights, and ensuring legal compliance. By providing clear terms and conditions for the use of your code, you invite others to contribute and use your project. Different open-source licenses, such as MIT, Apache, and GPL, offer various permissions and restrictions, so it's crucial to choose one that aligns with your project's goals and values. Overall, adding a license fosters a healthy and open development community while ensuring responsible and legal use of your software.
Please let me know if you have any questions, greetings, and Happy Coding!
If you can add this license your work will be complete, and the app will have protection.
Great job @CesarHerr
@ClaudiaRojasSoto The license has been included, thanks for your review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @CesarHerr , Your work is completed 💯
Great job so far!!.
Greetings and Happy Coding!
This pull request aims to merge the config-and-basic-setup branch into the develop branch of the repository. I have completed all the specific and general requirements for the basic project setup, as well as the following points:
Details
Config & Basic Setup:
General Requirements:
Thank you for reviewing and considering this pull request for merging into the "develop" branch!
@ClaudiaRojasSoto