Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/testing rockets #41

Merged
merged 8 commits into from
Jul 26, 2023
Merged

Conversation

ClaudiaRojasSoto
Copy link
Owner

Hello @CesarHerr ,

I am pleased to present the pull request for the "testing-rockets" feature branch. This pull request is now ready for merging into the "develop" branch as it fulfills all the general and specific requirements outlined below:

General Requirements:

  • Linter Errors: I have ensured that there are no linter errors in the codebase.
  • Gitflow: I have followed the correct Gitflow workflow throughout the development process.
  • Documentation: I have thoroughly documented my work in a professional manner to aid in future maintenance and understanding.

HTML/CSS & JavaScript Requirements:

  • Best Practices: I have adhered to the list of best practices for both HTML & CSS to maintain code quality and consistency.
  • JavaScript Best Practices: I have followed the recommended best practices for writing JavaScript code to ensure maintainability and readability.
  • Testing Libraries: I have set up the necessary testing libraries, specifically React Testing Library and Jest, to enable comprehensive testing of components and functions.

Test Requirements:

  • Test Coverage: I have written tests for all components and functions to ensure a high level of test coverage.

Please review this pull request carefully to ensure that all requirements have been met. Feel free to provide any feedback or suggestions for improvement. Once approved, I will proceed with the merge into the "develop" branch.

Thank you for your time and consideration.

Best regards,
@ClaudiaRojasSoto

@ClaudiaRojasSoto ClaudiaRojasSoto added the enhancement New feature or request label Jul 26, 2023
Copy link
Collaborator

@CesarHerr CesarHerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ClaudiaRojasSoto 👋,

STATUS: APPROVED 🕺🥳

Congratulations🍾🥳!!

  • All tests are Passing 🏁

Good luck! 🎉

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@ClaudiaRojasSoto ClaudiaRojasSoto merged commit 5bffa15 into develop Jul 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1pt] Write tests for rockets logic [1pt] Write tests for rockets components
2 participants