Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CNVkit container #1457

Merged
merged 22 commits into from
Jul 2, 2024
Merged

fix: CNVkit container #1457

merged 22 commits into from
Jul 2, 2024

Conversation

ivadym
Copy link
Contributor

@ivadym ivadym commented Jun 25, 2024

Description

Fix and clean CNVkit container.

Originally, I intended to update CNVkit to version 0.9.11. However, the new release includes some lazy requirements to fix previous dependency issues, which now block and break the installation. This has been reported in their issues. Therefore, I'm sticking with the previous version and pinning numpy to ensure the tools don't break.

Fixed

  • Pin numpy version in CNVkit container
  • CNVkit incorrect version in the documentation

Documentation

  • N/A
  • Updated Balsamic documentation to reflect the changes as needed for this PR.
    • [Document Name]

Tests

Feature Tests

  • N/A
  • Test cnvkit_segment_CNV_research does not break due to numpy major version release:

Pipeline Integrity Tests

  • Report deliver (generation of the .hk file)
    • N/A
    • Verified
  • TGA T/O Workflow
    • N/A
    • Verified
  • TGA T/N Workflow
    • N/A
    • Verified
  • UMI T/O Workflow
    • N/A
    • Verified
  • UMI T/N Workflow
    • N/A
    • Verified
  • WGS T/O Workflow
    • N/A
    • Verified
  • WGS T/N Workflow
    • N/A
    • Verified
  • QC Workflow
    • N/A
    • Verified
  • PON Workflow
    • N/A
    • Verified

Clinical Genomics Stockholm

Documentation

  • Atlas documentation
    • N/A
    • Updated: [Link]
  • Web portal for Clinical Genomics
    • N/A
    • Updated: [Link]

Panel of Normal specific criteria

User Changes

  • N/A
  • This PR affects the output files or results.
    • User feedback is considered unnecessary because [Justification].
    • Affected users have been included in the development process and given a chance to provide feedback.

Infrastructure Changes

  • Stored files in Housekeeper
    • N/A
    • Updated: [Link]
  • CG (CLI and delivered/uploaded files)
    • N/A
    • Updated: [Link]
  • Servers (configuration files on Hasta)
    • N/A
    • Updated: [Link]
  • Scout interface
    • N/A
    • Updated: [Link]

Checklist

Important

Ensure that all checkboxes below are ticked before merging.

For Developers

  • PR Description
    • Provided a comprehensive description of the PR.
    • Linked relevant user stories or issues to the PR.
  • Documentation
    • Verified and updated documentation if necessary.
  • Tests
    • Described and tested the functionality addressed in the PR.
    • Ensured integration of the new code with existing workflows.
    • Confirmed that meaningful unit tests were added for the changes introduced.
    • Checked that the PR has successfully passed all relevant code smells and coverage checks.
  • Review
    • Addressed and resolved all the feedback provided during the code review process.
    • Obtained final approval from designated reviewers.

For Reviewers

  • Code
    • Code implements the intended features or fixes the reported issue.
    • Code follows the project's coding standards and style guide.
  • Documentation
    • Pipeline changes are well-documented in the CHANGELOG and relevant documentation.
  • Tests
    • The author provided a description of their manual testing, including consideration of edge cases and boundary
      conditions where applicable, with satisfactory results.
  • Review
    • Confirmed that the developer has addressed all the comments during the code review.

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.48%. Comparing base (7d529e6) to head (cd1b3f2).
Report is 11 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1457   +/-   ##
========================================
  Coverage    99.48%   99.48%           
========================================
  Files           40       40           
  Lines         1932     1944   +12     
========================================
+ Hits          1922     1934   +12     
  Misses          10       10           
Flag Coverage Δ
unittests 99.48% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ivadym ivadym self-assigned this Jun 25, 2024
@ivadym ivadym mentioned this pull request Jun 25, 2024
7 tasks
@ivadym ivadym marked this pull request as ready for review July 2, 2024 13:26
@ivadym ivadym requested a review from a team as a code owner July 2, 2024 13:26
Copy link

sonarcloud bot commented Jul 2, 2024

Copy link
Contributor

@mathiasbio mathiasbio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Nicely done! :D 🌟

docs/balsamic_methods.rst Show resolved Hide resolved
@ivadym ivadym changed the title chore: Update CNVkit fix: fix CNVkit container Jul 2, 2024
@ivadym ivadym changed the title fix: fix CNVkit container fix: CNVkit container Jul 2, 2024
@ivadym ivadym merged commit bb03e67 into develop Jul 2, 2024
25 checks passed
@ivadym ivadym deleted the bump-cnvkit branch July 2, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants