Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GENS upload for TGA #3361

Merged
merged 9 commits into from
Sep 30, 2024
Merged

Add GENS upload for TGA #3361

merged 9 commits into from
Sep 30, 2024

Conversation

mathiasbio
Copy link
Contributor

@mathiasbio mathiasbio commented Jun 26, 2024

Description

GENS has previously only been activated for WGS in Balsamic, however with the inclusion of this PR into production Clinical-Genomics/BALSAMIC#1448 CNV and BAF profiles from TGA samples can be uploaded as well. This feature is planned for release 16.0.0 of Balsamic (somewhere around August maybe) and requires a couple of small changes in CG.

Added

  • gnomad-af argument to TGA samples

Changed

  • gens upload no longer filters out TGA samples

Fixed

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

Expected test outcome

  • Check that GENS files for TGA cases are now uploaded to GENS
  • Ensure that TGA case can be started with GENS arguments
  • Take a screenshot and attach or copy/paste the output. (See gnomad specific argument --gnomad-min-af5 , it is also picking up the new PON version)
image
  • Ensure that WGS case can STILL be started with GENS arguments
image

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

Copy link

sonarcloud bot commented Jun 26, 2024

@mathiasbio mathiasbio changed the base branch from master to balsamic_v16 July 22, 2024 11:23
@mathiasbio mathiasbio marked this pull request as ready for review September 23, 2024 09:46
@mathiasbio mathiasbio requested a review from a team as a code owner September 23, 2024 09:46
Copy link

sonarcloud bot commented Sep 30, 2024

@mathiasbio mathiasbio merged commit 4aa89ad into balsamic_v16 Sep 30, 2024
8 checks passed
@mathiasbio mathiasbio deleted the gens_for_tga branch September 30, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants