-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove alchy and use SQLAlchemy instead #59
Conversation
requirements.txt
Outdated
cairocffi | ||
chanjo>=4.1.0 | ||
chanjo @ git+https://github.com/Clinical-Genomics/chanjo@deprecate_alchy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work in PyPI, so we have to create a chanjo release first
@dnil I've created a PR that works in a combo with a chanjo one |
@@ -11,8 +11,6 @@ path.py | |||
pymysql | |||
pyscss | |||
six | |||
sqlservice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😸
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gets installed by chanjo, so it's not that the lib isn't going to be there..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you actually import something from it, or use it directly, it should certainly be here. If you don't... 😜
It's all good as it is now with this PR as well. Just saying. 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but we should test carefully with some real life cases in an integrated env (stage) before releasing!
@@ -11,8 +11,6 @@ path.py | |||
pymysql | |||
pyscss | |||
six | |||
sqlservice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you actually import something from it, or use it directly, it should certainly be here. If you don't... 😜
It's all good as it is now with this PR as well. Just saying. 😉
I agree! |
This is tested again after changing the requirements to use the new chanjo v4.7. Works fine so I'm merging! |
This PR adds | fixes:
How to prepare for test:
pip install -e .
chanjo init --auto demodata
chanjo --config demodata/chanjo.yaml link demodata/hgnc.grch37p13.exons.bed
Load 3 samples (coverage files are located in chanjo, not chanjo2)
chanjo --config demodata/chanjo.yaml load --sample sample1 --name sample1 --group-name test_group -g test_group <PATH_TO_CHANJO>/chanjo/init/demo-files/sample1.coverage.bed
chanjo --config demodata/chanjo.yaml load --sample sample2 --name sample2 --group-name test_group -g test_group <PATH_TO_CHANJO>/chanjo/init/demo-files/sample2.coverage.bed
chanjo --config demodata/chanjo.yaml load --sample sample3 --name sample3 --group-name test_group -g test_group <PATH_TO_CHANJO>/chanjo/init/demo-files/sample3.coverage.bed
How to test:
chanjo --config demodata/chanjo.yaml report --render html
http://localhost:5000/report?sample_id=sample1&sample_id=sample2&sample_id=sample3
http://localhost:5000/genes?level=10&sample_id=sample1&sample_id=sample2&sample_id=sample3
Expected outcome:
Review:
This version is a: