Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage upload hidden artifact new required option #75

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

dnil
Copy link
Collaborator

@dnil dnil commented Sep 4, 2024

Description

Fixed

  • codecov upload hidden artifact issue

How to test

  • Do allow GitHub actions automated tests to run

Expected test outcome

  • Check that coverage is uploaded
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.18%. Comparing base (acac2f6) to head (0e805b0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #75   +/-   ##
=======================================
  Coverage   91.18%   91.18%           
=======================================
  Files           8        8           
  Lines         397      397           
=======================================
  Hits          362      362           
  Misses         35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dnil dnil merged commit a7fcd76 into main Sep 4, 2024
12 checks passed
@dnil dnil deleted the fix_coverage_hidden_artifact branch September 26, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants