Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1934 Project Navigator does not show external updates to files and folders #1940

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

songemma
Copy link

Description

Fixed issues relating to project navigator; Project Navigator UI now responds to external filesystem updates (i.e. add file button now adds file to view, anything done to files in finder will update in view)

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Screen.Recording.2024-11-28.at.18.37.44.mov

Internal Filesystem Updates

Screen.Recording.2024-11-28.at.18.37.00.mov

External Filesystem Updates

@austincondiff
Copy link
Collaborator

@songemma Thank you for fixing this! I wonder if there is a bigger issue here though. In #1826 we see that when files are updated externally, the contents on their corresponding open editor in CodeEdit do not get updated in response.

After discussing this with other maintainers, we believe this is a result of an underlying issue where some updates are not making their way to the UI. You are welcome to dig into this further if you'd care to, otherwise please let us know and we can later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants