-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
118 pesel validation #140
Merged
Rafalkufel
merged 5 commits into
CodeForPoznan:master
from
damianwojtkowski:118-pesel-validation
Apr 24, 2020
Merged
118 pesel validation #140
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
47fc55a
Added helper file and prepared space for pesel validation
damianwojtkowski b990b4b
Added validator for pesel
damianwojtkowski d5ea880
Fixed lint errors
damianwojtkowski 9ac4e0e
Moved validators to one file and renamed file with validators
damianwojtkowski 461203c
Added tests for pesel validator
damianwojtkowski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
const required = value => (value ? undefined : "Required"); | ||
|
||
export const isPeselValid = pesel => { | ||
if (typeof pesel === "undefined" || !/^[0-9]{11}$/.test(pesel)) | ||
return "Type PESEL"; | ||
|
||
const weights = [1, 3, 7, 9, 1, 3, 7, 9, 1, 3]; | ||
let sum = 0; | ||
|
||
weights.forEach((weight, index) => { | ||
sum += weight * pesel.substring(index, index + 1); | ||
}); | ||
|
||
const checkSum = sum % 10 === 0 ? 0 : 10 - (sum % 10); | ||
|
||
if (checkSum !== +pesel.substring(10, 11)) return "Invalid PESEL"; | ||
}; | ||
|
||
export const composeValidators = validator => value => { | ||
return typeof validator === "undefined" ? required(value) : validator(value); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
import { isPeselValid } from "./validators"; | ||
|
||
describe("Validators", () => { | ||
it("returns valid pesel", () => { | ||
expect(isPeselValid("64042999928")).toBeUndefined(); | ||
}); | ||
|
||
it("return Type PESEL because of no value", () => { | ||
expect(isPeselValid(undefined)).toBe("Type PESEL"); | ||
}); | ||
|
||
it("return Type PESEL because of too short text", () => { | ||
expect(isPeselValid("9703100302")).toBe("Type PESEL"); | ||
}); | ||
|
||
it("return Invalid PESEL because of wrong numbers", () => { | ||
expect(isPeselValid("97031003021")).toBe("Invalid PESEL"); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a few unittests for checking if validators work are as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just create separated file e.g.
validators.test.js
and call a function with parameters.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test file with pesel validator test cases have been added.