target_suitecrm: add functionality to disable accounts instead of delete #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
edit: now resolved This currently decreases the test coverage. Need to add tests for:
|
Currently we delete any accounts which no longer exist in ldap. We suspect this will cause historic reporting to fail, and the recommendation from suitecrm is to disable users instead.
thinkl33t
force-pushed
the
bobclough/suitecrm_disable_users
branch
from
9a9a54a
to
1613fd1
Compare
thinkl33t
force-pushed
the
bobclough/suitecrm_disable_users
branch
from
fdec633
to
13bd2a3
Compare
richardmaw-codethink
approved these changes
Dec 8, 2023
Co-Authored-By: richardmaw-codethink <richard.maw@codethink.co.uk>
thinkl33t
force-pushed
the
bobclough/suitecrm_disable_users
branch
from
51f7b81
to
328b590
Compare
thinkl33t
requested review from
richardmaw-codethink and
garyianperkins
and removed request for
richardmaw-codethink
garyianperkins
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we delete any accounts which no longer exist in ldap. We suspect this will cause historic reporting to fail, and the recommendation from suitecrm is to disable users instead.