Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opdatering af alders-check ifm invitation: Håndtering af manglende fødselsdato #1088

Conversation

mhewel
Copy link
Contributor

@mhewel mhewel commented Jul 27, 2024

No description provided.

Copy link

what-the-diff bot commented Jul 27, 2024

PR Summary

  • Enhancements to Testing Procedure
    In members/tests/test_admin_admin_actions.py, there have been some important changes. A new case was added, represented by a person_without_age, who doesn't have a specified birthday. This helps to test the system's functionality when incomplete data is present. Additionally, the method create_person_and_waiting_list_entry() has been updated to efficiently handle scenarios where age or birthday remains unspecified.

  • Improvements to Age Verification Utility
    The age verification utility, located in members/utils/age_check.py, has received some crucial updates. If the person.birthday is missing, the methods check_is_person_too_young() and check_is_person_too_old() will now appropriately handle this by assuming that the person is excessively young or old. This change ensures the smooth functioning of age verification, even when the birthday data is incomplete.

Copy link
Contributor

@rasmusselsmark rasmusselsmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Har tilføjet tests, ser godt ud 👍

@rasmusselsmark rasmusselsmark merged commit 8022af6 into master Aug 31, 2024
5 checks passed
@rasmusselsmark rasmusselsmark deleted the 1077-bug-ved-invitation-af-visse-personer-fra-ventelisten-opleves-denne-fejl branch August 31, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Ved invitation af visse personer fra ventelisten opleves denne fejl
2 participants