-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deltagerlisten vist for aktiviteten (i Admin) indeholder nu også besked til arrangør, fototilladelse og betalingsinfo #920
Conversation
…ed til arrangør, fototilladelse og betalingsinfo
try: | ||
return self.payment_info(False) | ||
except Exception: | ||
return "Andet er aftalt" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vi bør ikke bruge en exception til at returnere en tekst - exceptions bør være håndtering af deciderede fejl.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
payment_info() er ændret, og de steder hvor payment_info() bliver kaldt er også ændret.
Det vil være lækkert hvis man ikke kan slette deltagere, samt aktiviteter der er deltagere på. |
Slet checkbox for deltagere er fjernet. |
…der-selve-aktivitetens-info
…der-selve-aktivitetens-info
…ivitetens-info' of https://github.com/CodingPirates/forenings_medlemmer into 908-feature-overblik-over-betalingsinfo-under-selve-aktivitetens-info
PR Summary
|
…der-selve-aktivitetens-info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gennemgået på Mikaels PC her til fysisk udviklerdag
…der-selve-aktivitetens-info
# Checking for price = 0 before checking for payment | ||
if self.activity.price_in_dkk == 0: | ||
result_string = f"{html_good_pre}Gratis.{html_post} " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flyt disse linjer op over try/except (linje 77).
Husk at returnere det, ellers udfører den fortsat det i try/except!
…der-selve-aktivitetens-info
eksempel: