Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permissions fetching for User Installable Bots #6457

Open
wants to merge 4 commits into
base: V3/develop
Choose a base branch
from

Conversation

Kowlin
Copy link
Member

@Kowlin Kowlin commented Sep 24, 2024

Description of the changes

This change fixes permissions regarding discord.Interactions and fetching permissions. Where this would fail where a bot isn't in the server (Yep, that's a thing now!) or doesn't have the channels cached in memory with interactions on User Installable Bots (UIBs) This fix pulls the permissions directly from the interaction, and gives the allowed permissions the interaction can use directly.

This will however sucks for bots trying to see if a person can ignore the ignore list. As its unclear to the bot if the author has manage_guild or similar permissions. But I see no other viable method of solving this.

Have the changes in this PR been tested?

Partially? (Lmao)

@github-actions github-actions bot added the Category: Core - Bot Class This is related to the `redbot.core.bot.Red` class. label Sep 24, 2024
@Kowlin Kowlin added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label Sep 24, 2024
@Kowlin Kowlin added this to the 3.5.14 milestone Sep 24, 2024
@Kowlin Kowlin requested a review from Copilot November 20, 2024 22:30

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Core - Bot Class This is related to the `redbot.core.bot.Red` class. Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant