-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[p]warn
ask to ban when user not in server
#6481
Conversation
…re not in the server
…dBot into V3/develop This is to add the extra feature for the [p]warn command, where now the user will be banned if they are found to have left the discord server instead. This suspect will be traced by their userIDc
My original comment was not intended to be complete approval of the idea of having this command default to banning the member if they have left the server. I think it could be useful to have it as an option (whether that be by asking if they should be banned as a prompt when Regarding the implementation of this fix, the Additionally, you are currently failing the style checks. Please format your PR with |
ok, I can add that as a prompt then. The bot should say "[User]" has left the server, so I cannot warn them. Would you like to ban them instead? [Y/N]". If the mod/owner responds with "Y", [User] will be banned. Else, no action will be taken. I will submit another PR request with the changes. |
…n a user if he is not present in the guild
*Reminder: the reason I used "[p]wasd" here is because I had to create a new separate cog in order to test for this kind of command. After I finished testing it, I carefully put in the modified parts. From this image, we can see that the bot eventually timed out after it hasn't received a proper command (either Y or N). The bot only registers the responses it expects. Otherwise it will not do anything and eventually time out. |
…ers who have already left the server
Implemented the fixes you have mentioned @Flame442 Here is what happens when you warn the user who is not in the server: Here is what happens when it times out after 10 seconds. |
…fore they can be warned
…fore they can be warned
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the ban is successful, it should create a modlog case (example).
Co-authored-by: Michael Oliveira <34169552+Flame442@users.noreply.github.com>
Co-authored-by: Michael Oliveira <34169552+Flame442@users.noreply.github.com>
Co-authored-by: Michael Oliveira <34169552+Flame442@users.noreply.github.com>
Co-authored-by: Michael Oliveira <34169552+Flame442@users.noreply.github.com>
Co-authored-by: Michael Oliveira <34169552+Flame442@users.noreply.github.com>
Co-authored-by: Michael Oliveira <34169552+Flame442@users.noreply.github.com>
…command if they have already left the server.
…sers who have already left the server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing!
[p]warn
ask to ban when user not in server
`[p]warn` ask to ban when user not in server (Cog-Creators#6481)
Description of the changes
This is to follow up with what @Flame442 said: "If a disruptive user is leaving before a moderator is able to take action, it may often make sense to consider them a troll and bypass the server's standard warnings track."
Instead of warning them, I check if they are in the discord guild; if they are not, then they will be banned.
Closes #6445
Have the changes in this PR been tested?
Note: the command here is "[p]wasd" because I tested it by implementing a new temporary cog.