-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Streams] Save/Remove/Check custom messages for each streamer. #6483
base: V3/develop
Are you sure you want to change the base?
[Streams] Save/Remove/Check custom messages for each streamer. #6483
Conversation
Unless I am misreading the diff at a glance, it looks like your commands ( For UX consideration - do we want there to be 3 commands for setting/checking/removing, or do we want to merge Additionally, you are currently failing the style checks. Please format your PR with |
Honestly I prefer group standards as well, the only things I've done so far are transfer the commits to keep the authors, make sure the .formats suppose i18n and adjust one of the things mentioned in the previous PR. The rest I've not touched, personally I'd agree with merging and having them as a group_sub. |
Type
Description of the changes
This is originally from @KianBral & @willkang-1, since the last PR has been idle for so long I decided to bring this back and work on it. This will close #4668, resolving #3824 and fixes #4984
This PR has not been tested, I have merged the previous authors' commits and work, while also slowly going through #4668 comments to handle the requested changes.
Have the changes in this PR been tested?
No